<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124519/">https://git.reviewboard.kde.org/r/124519/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch does not apply, it contains some changes that are already in master. How did you generate it? One way how this could happen is when you work on a branch, update it with the latest changes from master, and then create the diff using <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">git diff master</code> where master is the local, not yet updated master. If that wild guess is right, run <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">git diff origin/master</code> instead.</p></pre>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On August 3rd, 2015, 4:07 p.m. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2015, 4:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch introduces the CircleButton qml type. Based on this there is a button now which navigates the map at the current position.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems my distance or angle functions are not working well, the almost always provide false data after some panning (my position is sometimes start to change when I am panning on the map, strange thing: the position marker also starts to go to an other place like it is fixed to the screen, but the map moves under it sometimes when I am penning and it is not jumping back to its place.)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/android/drawable-xxxhdpi/backdrop.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/gps_fixed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/gps_not_fixed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/positionprovider/qtpositioning/QtPositioningPositionProviderPlugin.cpp <span style="color: grey">(1a11d67fba96f328a0a5aba7545fa4e93c597964)</span></li>
<li>src/lib/marble/declarative/SearchBackend.cpp <span style="color: grey">(05b768c5b2ec3cd549e3242cefaee2faaa423a53)</span></li>
<li>src/lib/marble/declarative/SearchBackend.h <span style="color: grey">(e320c484ff548bc678cc46fa13490af48718002a)</span></li>
<li>src/lib/marble/declarative/Routing.cpp <span style="color: grey">(078cbd6d64191bebf2dc3255986433c6a4503743)</span></li>
<li>src/lib/marble/declarative/Routing.h <span style="color: grey">(659f0120399197a3607acfbe874832da93687a09)</span></li>
<li>src/lib/marble/declarative/RouteRequestModel.cpp <span style="color: grey">(e23c9e12caf2d1f388f32f396cc4a404b7b490d3)</span></li>
<li>src/lib/marble/declarative/RouteRequestModel.h <span style="color: grey">(ba05435840d2558e847e1ffce85755fd5384660b)</span></li>
<li>src/lib/marble/declarative/MarbleQuickItem.cpp <span style="color: grey">(28f599c3b51c7bf993e40c6c97265f351fe02f17)</span></li>
<li>src/lib/marble/declarative/MarbleQuickItem.h <span style="color: grey">(cca329761f23cd72315df2d359166a2cbfa8056c)</span></li>
<li>src/lib/marble/declarative/MarbleDeclarativePlugin.cpp <span style="color: grey">(4f195ee1d4e4ab146a32c4c88513c4b80c938a67)</span></li>
<li>src/lib/marble/PluginManager.cpp <span style="color: grey">(5cc47b247c0e10329d6694e0b29fb1029145dd90)</span></li>
<li>src/apps/marble-touch/MainWidget.qml <span style="color: grey">(2ce63121caab5ae71c8655a9f3b967d9e456d549)</span></li>
<li>src/apps/marble-maps/Search.qml <span style="color: grey">(d30df076fb257ccfea917cba874df9e44caa956f)</span></li>
<li>src/apps/marble-maps/PositionButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/MarbleMaps.qrc <span style="color: grey">(2978e72c2fd12fe8435cfb3d5e5559982b41b110)</span></li>
<li>src/apps/marble-maps/MainScreen.qml <span style="color: grey">(ce36f04c61764c7d813608f3bb7aeb671731c5a4)</span></li>
<li>src/apps/marble-maps/CircularButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/BoxedText.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/marblelogo.png <span style="color: grey">(bf462f7608169f70cc014d8da1e0ad86e11bed15)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124519/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/35409caf-2dbd-4fc4-b495-43fe1d8e4279__gps_not_fixed.png">gps_not_fixed.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/019abdbb-80cf-4935-8d6d-0c3e6927d2b3__gps_fixed.png">gps_fixed.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/ebaa4d45-b337-4e42-8a23-a73e2d88ddca__marblelogo.png">marblelogo.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/dacf5958-7270-40c4-9031-243350a80de8__backdrop.png">backdrop.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>