[Marble-devel] Review Request 124583: Handle GPS suspend/resume and Open KML, GPX and OSM files

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124583/
-----------------------------------------------------------

(Updated Aug. 2, 2015, 8:59 a.m.)


Review request for Marble.


Changes
-------

Moved code from declarative/MarbleQuickItem to apps/marble-maps as it seems more application specific. Also extended it to handle files passed for opening. See updated description.


Summary (updated)
-----------------

Handle GPS suspend/resume and Open KML, GPX and OSM files


Repository: marble


Description (updated)
-------

At the moment GPS stays turned on when switching to a different app on Android. This should only be done when GPS is actively used e.g. for turn-by-turn navigation which we have not implemented yet. The patch catches the suspension state changes and shuts down or restarts position tracking accordingly.
While working on that I came across an easy way to retrieve file name arguments (or rather the Android equivalent way of handling it) and included that as well, using pretty much the same logic as on the Desktop. To handle this more application specific code I introduced a new class MarbleMaps which derives from MarbleQuickItem, but is located in apps/marble-maps and not declarative/MarbleQuickItem.


Diffs (updated)
-----

  src/apps/marble-maps/CMakeLists.txt 102dfc0 
  src/apps/marble-maps/MainScreen.qml ce36f04 
  src/apps/marble-maps/MarbleMaps.h PRE-CREATION 
  src/apps/marble-maps/MarbleMaps.cpp PRE-CREATION 
  src/apps/marble-maps/main.cpp f217139 
  src/apps/marble-maps/package/AndroidManifest.xml f5a1208 

Diff: https://git.reviewboard.kde.org/r/124583/diff/


Testing (updated)
-------

Switching between Marble Maps, homescreen and other apps on Nexus 4+7.
Tested opening some gpx, kml and osm files on Nexus 4+7.


File Attachments (updated)
----------------

Android "open with" dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/02/21242ba4-0d96-4e7a-abe7-8a37c857d217__android-file-open-with-marble.png
gpx file open and rendering
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/02/86d22876-0d14-4c81-afbf-7c4648c2fc16__android-vector-rendering-gpx.png
kml file open and rendering
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/02/cb4f56ca-cc62-4b27-8812-292dd6bccdca__android-vector-rendering-kml.png
osm file open and rendering (includes RR 124511)
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/02/f6ebd243-e421-4418-aa8f-afc085cfd982__android-vector-rendering-osm.png


Thanks,

Dennis Nienhüser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150802/eb51224b/attachment-0001.html>