<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124583/">https://git.reviewboard.kde.org/r/124583/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2015, 8:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Moved code from declarative/MarbleQuickItem to apps/marble-maps as it seems more application specific. Also extended it to handle files passed for opening. See updated description.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Handle GPS suspend/resume and Open KML, GPX and OSM files</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At the moment GPS stays turned on when switching to a different app on Android. This should only be done when GPS is actively used e.g. for turn-by-turn navigation which we have not implemented yet. The patch catches the suspension state changes and shuts down or restarts position tracking accordingly.
While working on that I came across an easy way to retrieve file name arguments (or rather the Android equivalent way of handling it) and included that as well, using pretty much the same logic as on the Desktop. To handle this more application specific code I introduced a new class MarbleMaps which derives from MarbleQuickItem, but is located in apps/marble-maps and not declarative/MarbleQuickItem.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Switching between Marble Maps, homescreen and other apps on Nexus 4+7.
Tested opening some gpx, kml and osm files on Nexus 4+7.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-maps/CMakeLists.txt <span style="color: grey">(102dfc0)</span></li>
<li>src/apps/marble-maps/MainScreen.qml <span style="color: grey">(ce36f04)</span></li>
<li>src/apps/marble-maps/MarbleMaps.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/MarbleMaps.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/main.cpp <span style="color: grey">(f217139)</span></li>
<li>src/apps/marble-maps/package/AndroidManifest.xml <span style="color: grey">(f5a1208)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124583/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/02/21242ba4-0d96-4e7a-abe7-8a37c857d217__android-file-open-with-marble.png">Android "open with" dialog</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/02/86d22876-0d14-4c81-afbf-7c4648c2fc16__android-vector-rendering-gpx.png">gpx file open and rendering</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/02/cb4f56ca-cc62-4b27-8812-292dd6bccdca__android-vector-rendering-kml.png">kml file open and rendering</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/02/f6ebd243-e421-4418-aa8f-afc085cfd982__android-vector-rendering-osm.png">osm file open and rendering (includes RR 124511)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>