[Marble-devel] Review Request 123577: Fixing bugs with the rotate and resize functionality of the GroundOverlayFrame

Dávid Kolozsvári freedawson at gmail.com
Thu Apr 30 21:59:19 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for Marble.

Repository: marble


This patch corrects some bugs of the GroundOverlayFrame, and adds more functionality to it. 
- Now it is possible to drag the parallel edges across each-other without experiencing glitches and bugs. For example switching the east and west edge now produces a GroundOverlayFrame which crosses the date line. 
- Adds "virtual nodes" to the boundary of the GroundOverlayFrame, in order to not experience glitches in extreme cases(e. g. the user rotates a big GroundOverlay which crosses the date line).
- Corrected a bug, where the polarity of the globe is not taken into account when adding a GroundOverlayFrame.

Besides that, this patch applies some code refactoring too, which probably improves performance(i. e. the interpolation is now taking place only when an update occurs, not in every repaint).


  src/plugins/render/annotate/AnnotatePlugin.cpp c27fd37 
  src/plugins/render/annotate/GroundOverlayFrame.h b069653 
  src/plugins/render/annotate/GroundOverlayFrame.cpp 26ea792 

Diff: https://git.reviewboard.kde.org/r/123577/diff/


It was tested by me and works fine.


Dávid Kolozsvári

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150430/becbe889/attachment-0001.html>

More information about the Marble-devel mailing list