[Marble-devel] Review Request 122725: Adds the possibility to choose between multiple formats for exporting coordinates via clipboard.

Marius Stanciu stanciumarius94 at gmail.com
Wed Apr 29 16:42:22 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated April 29, 2015, 4:42 p.m.)

Review request for Marble.


Shortened the pop-up dialog text ( removed "this can be changed in the settings dialog" );

Bugs: 344237

Repository: marble


The original code on copying coordinates function didn't respect the DRY principle as it was implemented DIFFERENTLY, in two separate locations: the Edit>Copy Coordinates action (QtMainWindow.cpp), RMB->Copy Coordinates ( MarbleWidgetPopupMenu.cpp )

To solve this, I created a new specialized class CopyCoordinatesDialog.{cpp,h,ui} which handled all the formating for the coordinates.
This class allows the user to PREVIEW and SELECT a format for exporting coordinates, all in a small window. The window pops up the first time a user tries to copy coordinates, and offers the option to not show again in the future.

It is also possible to modify the format option in the Settings dialog(as the window suggests).

The following formats have been added as an option:
     -Degree (DMS)  (human readable)
     -Degree (Decimal)   (human readable)
     -Universal Transverse Mercator (UTM) (human readable)
     -Longitude,Latitude (machine readable)
     -Latitude,Longitude (machine readable)
     -Geo: URI (machine readable)
     -Geo: URI with altitude (machine readable)
The exported object is a MimeData object composed by the following data:
     - text ( the formated coordinates )
     - KML representation
     - GPX representation

Diffs (updated)

  src/apps/marble-qt/QtMainWindow.h 595ffd2 
  src/apps/marble-qt/QtMainWindow.cpp c4280c6 
  src/lib/marble/CMakeLists.txt f448f84 
  src/lib/marble/MarbleViewSettingsWidget.ui 43e153e 
  src/lib/marble/QtMarbleConfigDialog.cpp ed5b62c 
  src/lib/marble/QtMarbleConfigDialog.h 1fbee43 
  src/lib/marble/MarbleWidgetPopupMenu.cpp 6756f49 
  src/lib/marble/MarbleWidget.cpp f83fcb8 
  src/lib/marble/MarbleWidget.h cd3b9bf 

Diff: https://git.reviewboard.kde.org/r/122725/diff/


was tested on master branch @ 20 feb


Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150429/5190f568/attachment.html>

More information about the Marble-devel mailing list