<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122725/">https://git.reviewboard.kde.org/r/122725/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<p style="color: grey;"><i>Updated April 29, 2015, 4:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shortened the pop-up dialog text ( removed "this can be changed in the settings dialog" );</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=344237">344237</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The original code on copying coordinates function didn't respect the DRY principle as it was implemented DIFFERENTLY, in two separate locations: the Edit>Copy Coordinates action (QtMainWindow.cpp), RMB->Copy Coordinates ( MarbleWidgetPopupMenu.cpp )</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To solve this, I created a new specialized class CopyCoordinatesDialog.{cpp,h,ui} which handled all the formating for the coordinates.
This class allows the user to PREVIEW and SELECT a format for exporting coordinates, all in a small window. The window pops up the first time a user tries to copy coordinates, and offers the option to not show again in the future.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is also possible to modify the format option in the Settings dialog(as the window suggests).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The following formats have been added as an option:
-Degree (DMS) (human readable)
-Degree (Decimal) (human readable)
-Universal Transverse Mercator (UTM) (human readable)
-Longitude,Latitude (machine readable)
-Latitude,Longitude (machine readable)
-Geo: URI (machine readable)
-Geo: URI with altitude (machine readable)
-
The exported object is a MimeData object composed by the following data:
- text ( the formated coordinates )
- KML representation
- GPX representation</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">was tested on master branch @ 20 feb</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-qt/QtMainWindow.h <span style="color: grey">(595ffd2)</span></li>
<li>src/apps/marble-qt/QtMainWindow.cpp <span style="color: grey">(c4280c6)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(f448f84)</span></li>
<li>src/lib/marble/MarbleViewSettingsWidget.ui <span style="color: grey">(43e153e)</span></li>
<li>src/lib/marble/QtMarbleConfigDialog.cpp <span style="color: grey">(ed5b62c)</span></li>
<li>src/lib/marble/QtMarbleConfigDialog.h <span style="color: grey">(1fbee43)</span></li>
<li>src/lib/marble/MarbleWidgetPopupMenu.cpp <span style="color: grey">(6756f49)</span></li>
<li>src/lib/marble/MarbleWidget.cpp <span style="color: grey">(f83fcb8)</span></li>
<li>src/lib/marble/MarbleWidget.h <span style="color: grey">(cd3b9bf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122725/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>