[Marble-devel] Review Request 123343: MessageBox asking to save tour when closing

SIlvia Pripoae pripoaesilvia at gmail.com
Sat Apr 18 09:56:19 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated April 18, 2015, 9:56 a.m.)

Review request for Marble, Calin Cruceru and Torsten Rahn.


I applied the changes for the KDE version also.
There is a bug, that existed before this patch, that marble(the KDE version) crashes when it closes if a tour exists.

Repository: marble


Before this patch, when closing Marble, any unsaved tours were discarded. Now, a message box asking whether to save the tour is displayed.

Diffs (updated)

  src/apps/marble-kde/KdeMainWindow.h 7a94119 
  src/apps/marble-kde/KdeMainWindow.cpp bebb8a1 
  src/apps/marble-qt/QtMainWindow.h 595ffd2 
  src/apps/marble-qt/QtMainWindow.cpp c4280c6 
  src/apps/marble-ui/ControlView.h 21d58cf 
  src/apps/marble-ui/ControlView.cpp a16aa28 
  src/lib/marble/TourWidget.h a6cb8ca 
  src/lib/marble/TourWidget.cpp b9fab0e 

Diff: https://git.reviewboard.kde.org/r/123343/diff/


Works for me.


SIlvia Pripoae

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150418/f9723f58/attachment.html>

More information about the Marble-devel mailing list