[Marble-devel] Review Request 123343: MessageBox asking to save tour when closing

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123343/#review78872
-----------------------------------------------------------



src/lib/marble/TourWidget.cpp (line 335)
<https://git.reviewboard.kde.org/r/123343/#comment53933>

    I wonder if we can use (or introduce) some other means than the action state to determine what to do. Both the action state and this code would then base on it. For example a boolean member variable m_tourUnsaved.


- Dennis Nienhüser


On April 12, 2015, 12:12 nachm., SIlvia Pripoae wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123343/
> -----------------------------------------------------------
> 
> (Updated April 12, 2015, 12:12 nachm.)
> 
> 
> Review request for Marble, Calin Cruceru and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Before this patch, when closing Marble, any unsaved tours were discarded. Now, a message box asking whether to save the tour is displayed.
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-ui/ControlView.h 21d58cf 
>   src/apps/marble-ui/ControlView.cpp a16aa28 
>   src/lib/marble/TourWidget.h a6cb8ca 
>   src/apps/marble-qt/QtMainWindow.cpp c4280c6 
>   src/lib/marble/TourWidget.cpp b9fab0e 
> 
> Diff: https://git.reviewboard.kde.org/r/123343/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> SIlvia Pripoae
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150412/a20bae66/attachment.html>