[Marble-devel] Review Request 118042: Extend the GeoDataWriter unit test to test operator== of GeoDataDocument

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118042/#review57531
-----------------------------------------------------------


This review has been submitted with commit 68107fec8a3249d31fab9aa972c1ce7780958aef by Cruceru Calin-Cristian to branch master.

- Commit Hook


On May 7, 2014, 7:59 p.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118042/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 7:59 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 334289
>     http://bugs.kde.org/show_bug.cgi?id=334289
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Implemented saveAndCompareEquality within TestGeoDataWriter which is based on the current function, saveAndCompare. This function compares the actual file and the parsed & written file, using QTextStream's. 
> 
> My implementation uses the newly implemented GeoDataDocument::operator==.
> 
> 
> Diffs
> -----
> 
>   tests/TestGeoDataWriter.cpp 6147697 
> 
> Diff: https://git.reviewboard.kde.org/r/118042/diff/
> 
> 
> Testing
> -------
> 
> All tests finish as expected, only after making the change proposed here: https://git.reviewboard.kde.org/r/118040/.
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140507/46277aa6/attachment-0001.html>