[Marble-devel] Review Request 118042: Extend the GeoDataWriter unit test to test operator== of GeoDataDocument

Cruceru Calin-Cristian crucerucalincristian at gmail.com
Wed May 7 19:59:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118042/
-----------------------------------------------------------

Review request for Marble.


Bugs: 334289
    http://bugs.kde.org/show_bug.cgi?id=334289


Repository: marble


Description
-------

Implemented saveAndCompareEquality within TestGeoDataWriter which is based on the current function, saveAndCompare. This function compares the actual file and the parsed & written file, using QTextStream's. 

My implementation uses the newly implemented GeoDataDocument::operator==.


Diffs
-----

  tests/TestGeoDataWriter.cpp 6147697 

Diff: https://git.reviewboard.kde.org/r/118042/diff/


Testing
-------

All tests finish as expected, only after making the change proposed here: https://git.reviewboard.kde.org/r/118040/.


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140507/9a5a9d0a/attachment.html>


More information about the Marble-devel mailing list