[Marble-devel] Review Request 116525: Added support to download remote images/icons

[Abhinav Gangwar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116525/
-----------------------------------------------------------

(Updated March 21, 2014, 8:18 a.m.)


Review request for Marble, Bernhard Beschow and Thibaut Gridel.


Changes
-------

Added signal to in RemoteIconLoader and VisiblePlacemark to make the icon display on map as soon as it is downloaded by RemoteIconLoader by triggering the repaint. In the earlier patch it has to wait for the next repaint to be triggered to display the icon on map.


Bugs: 310464
    http://bugs.kde.org/show_bug.cgi?id=310464


Repository: marble


Description
-------

The patch adds support to download remote images


Diffs (updated)
-----

  src/lib/marble/CMakeLists.txt bb6f312 
  src/lib/marble/PlacemarkLayout.h 73ea249 
  src/lib/marble/PlacemarkLayout.cpp 408607b 
  src/lib/marble/RemoteIconLoader.h PRE-CREATION 
  src/lib/marble/RemoteIconLoader.cpp PRE-CREATION 
  src/lib/marble/VisiblePlacemark.h 879e384 
  src/lib/marble/VisiblePlacemark.cpp 8811598 
  src/lib/marble/geodata/data/GeoDataIconStyle.h 9a4abbf 
  src/lib/marble/geodata/data/GeoDataIconStyle.cpp b8310cf 

Diff: https://git.reviewboard.kde.org/r/116525/diff/


Testing
-------

Works fine on my system


Thanks,

Abhinav Gangwar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140321/7d26e2eb/attachment.html>