[Marble-devel] Review Request 116525: Added support to download remote images/icons

[Abhinav Gangwar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116525/
-----------------------------------------------------------

(Updated March 10, 2014, 9:25 p.m.)


Review request for Marble, Bernhard Beschow and Thibaut Gridel.


Changes
-------

Bernhard, Thibaut, I'll add you as reviewers to give you a chance to propose alternatives to pushing this to master directly (see the general issues in my first review). The code looks fine to me otherwise.


Bugs: 310464
    http://bugs.kde.org/show_bug.cgi?id=310464


Repository: marble


Description
-------

The patch adds support to download remote images


Diffs
-----

  src/lib/marble/geodata/data/GeoDataIconStyle.cpp b8310cf 
  src/lib/marble/RemoteIconLoader.cpp PRE-CREATION 
  src/lib/marble/CMakeLists.txt bb6f312 
  src/lib/marble/RemoteIconLoader.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116525/diff/


Testing
-------

Works fine on my system


Thanks,

Abhinav Gangwar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140310/79cd32ae/attachment.html>