[Marble-devel] Review Request 116797: Bug 331992 - Playlist item styling for KML Tours

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116797/#review53443
-----------------------------------------------------------


This review has been submitted with commit ffb9e01a3c33ddffd72fc6458e8fa593e93fd1b0 by Dennis Nienhüser on behalf of Cruceru Calin-Cristian to branch master.

- Commit Hook


On March 17, 2014, 10:04 p.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116797/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 10:04 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331992
>     http://bugs.kde.org/show_bug.cgi?id=331992
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I created a QStyledItemDelegate derived class in TourWidget.cpp which renders all playlist items. Also, I had to add some cases in GeoDataTreeModel.cpp in order to filter GeoDataWait/SoundCue/TourControl. If there is an easier method to do this and doesn't imply modifying GeoDataTreeModel.cpp, tell me and I'll adapt the code.
> One more thing to mention is that I tried to add a suggestive icon to the edit and play buttons but I couldn't find the pictures' names.
> 
> 
> Diffs
> -----
> 
>   data/bitmaps/audio-x-generic.png PRE-CREATION 
>   data/bitmaps/document-edit.png PRE-CREATION 
>   data/bitmaps/media-playback-pause.png PRE-CREATION 
>   data/bitmaps/player-time.png PRE-CREATION 
>   src/lib/marble/TourWidget.cpp da924f2 
>   src/lib/marble/libmarble.qrc d19c595 
> 
> Diff: https://git.reviewboard.kde.org/r/116797/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140319/c9886b58/attachment.html>