<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116797/">https://git.reviewboard.kde.org/r/116797/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ffb9e01a3c33ddffd72fc6458e8fa593e93fd1b0 by Dennis Nienhüser on behalf of Cruceru Calin-Cristian to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 17th, 2014, 10:04 p.m. UTC, Cruceru Calin-Cristian wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<p style="color: grey;"><i>Updated March 17, 2014, 10:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331992">331992</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I created a QStyledItemDelegate derived class in TourWidget.cpp which renders all playlist items. Also, I had to add some cases in GeoDataTreeModel.cpp in order to filter GeoDataWait/SoundCue/TourControl. If there is an easier method to do this and doesn't imply modifying GeoDataTreeModel.cpp, tell me and I'll adapt the code.
One more thing to mention is that I tried to add a suggestive icon to the edit and play buttons but I couldn't find the pictures' names.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/bitmaps/audio-x-generic.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/document-edit.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/media-playback-pause.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/bitmaps/player-time.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/TourWidget.cpp <span style="color: grey">(da924f2)</span></li>
<li>src/lib/marble/libmarble.qrc <span style="color: grey">(d19c595)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116797/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>