[Marble-devel] Review Request 116534: Test equality of GeoDataObject derived classes

[Cruceru Calin-Cristian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116534/
-----------------------------------------------------------

Review request for Marble.


Bugs: 331666
    http://bugs.kde.org/show_bug.cgi?id=331666


Repository: marble


Description
-------

Adds a protected method in GeoDataObject that compare the id and targetId of two objets of this type.
Calls this method in each method implementing operator== of classes derived directly or indirectly from GeoObejectData.

PS: Waiting for BUG 331673 to be done and I'll update the patch for those classes too.


Diffs
-----

  src/lib/marble/geodata/data/GeoDataSimpleArrayData.cpp 689ea91 
  src/lib/marble/geodata/data/GeoDataPlacemark.cpp 6ede0fb 
  src/lib/marble/geodata/data/GeoDataObject.h db612bd 
  src/lib/marble/geodata/data/GeoDataObject.cpp 21537fc 
  src/lib/marble/geodata/data/GeoDataLink.cpp 57c4502 
  src/lib/marble/geodata/data/GeoDataBalloonStyle.cpp 70d8730 
  src/lib/marble/geodata/data/GeoDataCamera.cpp 0f6567d 
  src/lib/marble/geodata/data/GeoDataColorStyle.cpp 054bbfa 
  src/lib/marble/geodata/data/GeoDataData.cpp c0ef030 
  src/lib/marble/geodata/data/GeoDataExtendedData.cpp 1b284bc 
  src/lib/marble/geodata/data/GeoDataFlyTo.cpp 245c1d9 
  src/lib/marble/geodata/data/GeoDataHotSpot.cpp 411aaa7 
  src/lib/marble/geodata/data/GeoDataImagePyramid.cpp 38043b2 
  src/lib/marble/geodata/data/GeoDataItemIcon.cpp 57c23ff 
  src/lib/marble/geodata/data/GeoDataLatLonAltBox.cpp 8a64378 
  src/lib/marble/geodata/data/GeoDataLatLonBox.cpp 7ad0430 

Diff: https://git.reviewboard.kde.org/r/116534/diff/


Testing
-------


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140302/ee38ef83/attachment-0001.html>