<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116534/">https://git.reviewboard.kde.org/r/116534/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Cruceru Calin-Cristian.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331666">331666</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a protected method in GeoDataObject that compare the id and targetId of two objets of this type.
Calls this method in each method implementing operator== of classes derived directly or indirectly from GeoObejectData.
PS: Waiting for BUG 331673 to be done and I'll update the patch for those classes too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataSimpleArrayData.cpp <span style="color: grey">(689ea91)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPlacemark.cpp <span style="color: grey">(6ede0fb)</span></li>
<li>src/lib/marble/geodata/data/GeoDataObject.h <span style="color: grey">(db612bd)</span></li>
<li>src/lib/marble/geodata/data/GeoDataObject.cpp <span style="color: grey">(21537fc)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLink.cpp <span style="color: grey">(57c4502)</span></li>
<li>src/lib/marble/geodata/data/GeoDataBalloonStyle.cpp <span style="color: grey">(70d8730)</span></li>
<li>src/lib/marble/geodata/data/GeoDataCamera.cpp <span style="color: grey">(0f6567d)</span></li>
<li>src/lib/marble/geodata/data/GeoDataColorStyle.cpp <span style="color: grey">(054bbfa)</span></li>
<li>src/lib/marble/geodata/data/GeoDataData.cpp <span style="color: grey">(c0ef030)</span></li>
<li>src/lib/marble/geodata/data/GeoDataExtendedData.cpp <span style="color: grey">(1b284bc)</span></li>
<li>src/lib/marble/geodata/data/GeoDataFlyTo.cpp <span style="color: grey">(245c1d9)</span></li>
<li>src/lib/marble/geodata/data/GeoDataHotSpot.cpp <span style="color: grey">(411aaa7)</span></li>
<li>src/lib/marble/geodata/data/GeoDataImagePyramid.cpp <span style="color: grey">(38043b2)</span></li>
<li>src/lib/marble/geodata/data/GeoDataItemIcon.cpp <span style="color: grey">(57c23ff)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLatLonAltBox.cpp <span style="color: grey">(8a64378)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLatLonBox.cpp <span style="color: grey">(7ad0430)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116534/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>