[Marble-devel] Review Request 118495: Marble input handling refactor. Support for mouse, touch and pinch in MarbleQuickItem.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118495/#review59089
-----------------------------------------------------------


Haven't had a deeper look yet but at first sight this looks really nice :)

- Torsten Rahn


On June 3, 2014, 12:36 p.m., Adam Dabrowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118495/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 12:36 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Functionalities:
> - Mouse, touch and pinch input handling for MarbleQuickItem (keyboard was enabled earlier)
> 
> Other changes: 
> - Refactored input handling to reuse code, broke into smaller pieces (functions)
> - Extended the example (marbleQuick2)
> 
> Known issues: 
> - Some refactoring still should be done around input classes
> - Inertial rotation is disabled by default in MarbleQuickItem because of some issues (mostly touch-related). However, issues are rather minor so feel free to enable it back.
> 
> 
> Diffs
> -----
> 
>   examples/cpp/marbleQuick2/main.cpp 640baa6 
>   examples/cpp/marbleQuick2/main.qml 76947ed 
>   src/lib/marble/CMakeLists.txt 4add26b 
>   src/lib/marble/MarbleAbstractPresenter.h 7c047ed 
>   src/lib/marble/MarbleAbstractPresenter.cpp 98855bb 
>   src/lib/marble/MarbleInputHandler.h PRE-CREATION 
>   src/lib/marble/MarbleInputHandler.cpp PRE-CREATION 
>   src/lib/marble/MarbleQuickItem.h 8fd5657 
>   src/lib/marble/MarbleQuickItem.cpp 0ccc0ac 
>   src/lib/marble/MarbleWidget.cpp acc270a 
>   src/lib/marble/MarbleWidgetInputHandler.h f763d1e 
>   src/lib/marble/MarbleWidgetInputHandler.cpp 912c12d 
> 
> Diff: https://git.reviewboard.kde.org/r/118495/diff/
> 
> 
> Testing
> -------
> 
> - Using these changes since some time in a working app that is based on a MarbleQuickItem subclass (on both unix PC and a touch device)
> - Built and run marbleQuick2 example on both PC and a touch device.
> - Did good tests for MarbleQuickItem, basic regression testing for MarbleWidget and no testing for Qt4.
> 
> 
> Thanks,
> 
> Adam Dabrowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140603/355c8f76/attachment.html>