[Marble-devel] Review Request 119555: Added copy and cut actions on polygons/placemarks

Thu Jul 31 16:57:27 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119555/
-----------------------------------------------------------

Review request for Marble.

Repository: marble

Description
-------

As the title says, I decided to add Copy/Cut actions on Annotate Plugin's scene graphic items. However, I ended up implementing these two actions only on polygons and placemarks because, as you know, ground overlays are not very consistent in implementation with the other ones, since it makes use of the texture layer to get rendered. However, if the issues I will mention below regarding this implementation will be solved, I will implement those too, so that even if it is not consistent with the others regarding the implementation, at least to look consistent to the user, which, in the end, is the most important.

So I decided to implement these actions mainly because I thought they will add consistency to annotate plugin and would improve its flexibility. It also improved the way Annotate Plugin treats scene graphic items since, as you can see in the patch, there is only one implementation of cut/copy/paste and not one for each annotate item.

How it works: simply right click on placemarks or polygons and click copy/cut. At this point, the item you selected is added to a clipboard. Then, right click anywhere on the map and click 'Paste Graphic Item'. This is an action I added to the m_marbleWidget->popupMenu() (this is disabled when the clipboard is empty).

What are the issues:
- placemark related:
    - copy works fine;
    - there is some weird behaviour when cutting, which sometimes leads to crashes. I uploaded a video to show it better. There is obvious something related to the dateline, but I couldn't figure out what exactly. I really need help on this one. I also uploaded a crash log.

- polygon related:
    - when I try to copy a polygon and then paste it, it leads to some weird behaviour in which there are (seemingly) two polygons with the same geometry, rendered one over the other. I also uploaded a screencast which shows better this behaviour.
    - cutting works fine; However, there is also the problem which is already known: the cutting is done by actually moving the whole polygon from the first clicked point to the point where the 'Paste Graphic Item' action has been triggered. This causes the polygon to change its shape due to the way the moving is done at the moment.

I'm waiting feedback and, very important, suggestions on what is causing the mentioned issues.

Diffs
-----

  src/plugins/render/annotate/AnnotatePlugin.h 19520d7 
  src/plugins/render/annotate/AnnotatePlugin.cpp d139e1c 
  src/plugins/render/annotate/AreaAnnotation.h ee88e51 
  src/plugins/render/annotate/AreaAnnotation.cpp 4ba7a74 
  src/plugins/render/annotate/EditTextAnnotationDialog.h 63f8f6c 
  src/plugins/render/annotate/EditTextAnnotationDialog.cpp de07c49 
  src/plugins/render/annotate/GroundOverlayFrame.h 7562e18 
  src/plugins/render/annotate/GroundOverlayFrame.cpp 078df7e 
  src/plugins/render/annotate/MergingNodesAnimation.h e7e8e30 
  src/plugins/render/annotate/MergingNodesAnimation.cpp 3ec6469 
  src/plugins/render/annotate/PlacemarkTextAnnotation.h c23fa20 
  src/plugins/render/annotate/PlacemarkTextAnnotation.cpp 844b733 
  src/plugins/render/annotate/SceneGraphicsItem.h 28bf5d3 

Diff: https://git.reviewboard.kde.org/r/119555/diff/

Testing
-------

File Attachments
----------------

Placemark weird behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/ca91b55e-ac1c-4619-8c88-59cf70362284__placemark.avi
Polygon weird behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/278c2bdf-244e-4ee0-aa31-6484aa44e72d__polygon.avi
crash_log
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/67a57c8b-3ba2-4014-99de-06bf0f75d4b8__crash_log1.txt

Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140731/020cec38/attachment.html>