[Marble-devel] Review Request 119538: Support of multiple MarbleWidgets and creating MapTheme from GeoDataPhotoOverlay

[Gábor Péterffy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119538/
-----------------------------------------------------------

(Updated júl. 31, 2014, 10:52 de)


Review request for Marble and Torsten Rahn.


Changes
-------

More bugs...


Repository: marble


Description (updated)
-------

This is the next step toward the photoOverlay viewer. It includes the gnomonic projection code of shentey from https://github.com/shentok/marble/tree/streetview/src.

The basic things what have been done:
- Now multiple MarbleWidget can be present at the same time, this is controlled by the ControlView
- The MapThemeManager can create a working mapTheme from a GeoDataPhotoOverlay
- The needed resources for the image viewer are stored in a temporary directory

Known bugs:
- Can't turn off the plugins (e.g. compass, map-overview, grid, ...) with the properties in the GeoSceneDocument (cause currently unknown)
- The new widget doesn't get the focus despite the invoke of setFocus()
- If Marble closed when a panorama is open, it try to save it as the last open MapTheme


Diffs
-----

  data/bitmaps/webpopup/icon-panorama.png PRE-CREATION 
  src/apps/marble-ui/ControlView.h cea9dc04926330222faaa8b729963a0bf7bba43c 
  src/apps/marble-ui/ControlView.cpp 31294fc145b6244a0e1d1aa053a052f8dfdb947d 
  src/lib/marble/MarbleWidget.h dfc1aa7bc8004e96a7759d06165580bf8c56b63c 
  src/lib/marble/MarbleWidget.cpp d4c7ff48145bd55de23cf0a0e4a2b92e8037bb29 
  src/lib/marble/MarbleWidgetPopupMenu.cpp 1dc7760903f4899e830d754957651c6681172971 
  src/lib/marble/PopupItem.h 4c65004d1386305c3394f5b343bc67cff9127f39 
  src/lib/marble/PopupItem.cpp a4e973ad60a2a8dd24fc5370b6eaf95b247f5bb5 
  src/lib/marble/RenderPlugin.h 67472fa005f191c823f188848926f87150ba9c98 
  src/lib/marble/RenderPlugin.cpp 1f2e9b1f679914a96337042fd6d9b347dac2533e 
  src/lib/marble/TileCreator.cpp e54a62e42faa940fbe3cb255ae2a03bba702d70b 
  src/lib/marble/ViewportParams.cpp d6cf03603b353671f52440adcea15ddecf188b94 
  src/lib/marble/WebPopupWidget.ui 8cf7103185281833924b0e36da655b2fbe19b8b6 
  src/lib/marble/geodata/data/GeoDataPhotoOverlay.cpp 5a3cbc3f59960e5a23f410be45837b4d17be16b2 
  src/lib/marble/geodata/data/GeoDataPlacemark.h 96028e426a9688ffbb48cf8942eba2455a06b581 
  src/lib/marble/geodata/data/GeoDataPlacemark.cpp b2d0304ec10e2243538cf1cdb252c2da7f0cde5c 
  src/lib/marble/geodata/data/GeoDataPlacemark_p.h b4c1ee1a7f53d596baada68c94bba72cb26a9e53 
  src/lib/marble/geodata/graphicsitem/GeoPhotoGraphicsItem.cpp 4fab8fb25528706527e9138d10a4850c20025437 
  src/lib/marble/geodata/scene/GeoSceneDocument.h 2c12be288f06a1384704a5b63721001a9c0086be 
  src/lib/marble/geodata/scene/GeoSceneDocument.cpp 6c36b0a66392600624b2371693e8e3ebcd027401 
  src/lib/marble/layers/GeometryLayer.h 8d86aed059f7d6e36fd668bedb1f26d467cd2887 
  src/lib/marble/layers/GeometryLayer.cpp fbfe9a379ef6308d065d00b9b75188e8b33f1054 
  src/lib/marble/layers/PopupLayer.h 8f9fcc66c8a6def5249757d7f17c22427aa87699 
  src/lib/marble/layers/PopupLayer.cpp b7abd977eb140add867b7b347242d636e8c1c757 
  src/lib/marble/layers/TextureLayer.cpp 845b032c7b7603af5af0bdb9064b01e0a0817af3 
  src/lib/marble/libmarble.qrc 4ff9bf7cd37241ba879d332104d4418a7ac60836 
  src/lib/marble/projections/GnomonicProjection.h PRE-CREATION 
  src/lib/marble/projections/GnomonicProjection.cpp PRE-CREATION 
  src/lib/marble/webpopup/photooverlay.html PRE-CREATION 
  src/plugins/declarative/MarbleDeclarativeWidget.cpp 0cb6c94d584f385317caa8e88f19fbfec57a5a95 
  src/lib/marble/CMakeLists.txt d9e94b5ec2f552827258152445abc962a463dea9 
  src/lib/marble/FileStoragePolicy.h aaff71a2c3e40e618d5370d463e4a9edab55011f 
  src/lib/marble/FileStoragePolicy.cpp 559495423fd5b8ad6450234a89902f0f1896cd8c 
  src/lib/marble/GnomonicScanlineTextureMapper.h PRE-CREATION 
  src/lib/marble/GnomonicScanlineTextureMapper.cpp PRE-CREATION 
  src/lib/marble/MapThemeManager.h d18c8de6ec29153e00d079a4b30579ca1d9be14d 
  src/lib/marble/MapThemeManager.cpp ac40bed18c50aac1e2d90c89bd271b80124970a6 
  src/lib/marble/MarbleGlobal.h 69a96f3badc69edc36a0163a173f7214fe71aeb5 
  src/lib/marble/MarbleMap.cpp 25007ac7921df3ca447eb587e9d12ffc838e6856 
  src/lib/marble/MarbleModel.h 9643186b62429a4e04f421030d64b8ab86cd7f7c 
  src/lib/marble/MarbleModel.cpp d240bacb24fd25c84d7dc5646c3264d854840841 

Diff: https://git.reviewboard.kde.org/r/119538/diff/


Testing
-------


Thanks,

Gábor Péterffy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140731/f5f8401f/attachment.html>