[Marble-devel] Review Request 119264: Added " identify the country shape" game.

[Abhinav Gangwar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119264/
-----------------------------------------------------------

(Updated July 25, 2014, 11:50 a.m.)


Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.


Changes
-------

1. Modified the game panel ( dock widget at left ) - It now shows a QQuickWindow which opens the .qml file for this panel.
 
QML Changes:

2. window.qml shows initial menu - "Browse Map" and "Play Game"
3. GameOptions.qml file contains the game menu ( available games ).
4. GamesView.qml file contains a VisualItemModel which contains items CountryByShape and CountryByFlag ( for different types of  
   games ). This data is shown by a ListView.
5. CountryByShape.qml contains UI to be dislayed for "identify the country shape game" and similary CountryByFlag.qml for 
   "identify the flag" game.
6. CustomRadioButton.qml uses a RadioButtom item and provides some customizable properties like - buttonWidth, labelColor etc. 
7. Similarly CustomButton.qml provides a Custom Button item.

C++ changes:
8. Refactored code and moved code for different types of games in separate files ( CountryByShape.cpp and CountryByFlag.cpp ).


I had almost no experince with qml and this is my second time I wrote qml code. So, there may be some design flaws. Please check the qml files.

ThankYou :)


Repository: marble


Description
-------

Added "identify the country shape" game.
1. Game randomly highlights a country on political map.
2. It displays random answer options out of which only one is correct. The user needs to check the button 
   displaying correct option.

Here is a video showing the game http://youtu.be/kr0HsxLWXPs .

The game needs the patch https://git.reviewboard.kde.org/r/118717/ to work.


Diffs (updated)
-----

  src/apps/marble-game/GameMainWindow.h PRE-CREATION 
  src/apps/marble-game/GameMainWindow.cpp PRE-CREATION 
  src/apps/marble-game/GameOptions.qml PRE-CREATION 
  src/apps/marble-game/GamesView.qml PRE-CREATION 
  src/apps/marble-game/game.ui PRE-CREATION 
  src/apps/marble-game/gamemain.cpp PRE-CREATION 
  src/apps/marble-game/marble.rc PRE-CREATION 
  src/apps/marble-game/window.qml PRE-CREATION 
  src/lib/marble/FileManager.h 33de7cc 
  src/apps/CMakeLists.txt 022cd02 
  src/apps/marble-game/CMakeLists.txt PRE-CREATION 
  src/apps/marble-game/CountryByFlag.h PRE-CREATION 
  src/apps/marble-game/CountryByFlag.cpp PRE-CREATION 
  src/apps/marble-game/CountryByFlag.qml PRE-CREATION 
  src/apps/marble-game/CountryByShape.h PRE-CREATION 
  src/apps/marble-game/CountryByShape.cpp PRE-CREATION 
  src/apps/marble-game/CountryByShape.qml PRE-CREATION 
  src/apps/marble-game/CustomButton.qml PRE-CREATION 
  src/apps/marble-game/CustomRadioButton.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119264/diff/


Testing
-------

Works fine here :) .


File Attachments
----------------

game.diff
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/14/d66172dc-0395-45a1-90de-403b411d1a5f__game.diff


Thanks,

Abhinav Gangwar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140725/a0a1a44b/attachment.html>