<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119264/">https://git.reviewboard.kde.org/r/119264/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.</div>
<div>By Abhinav Gangwar.</div>
<p style="color: grey;"><i>Updated July 25, 2014, 11:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Modified the game panel ( dock widget at left ) - It now shows a QQuickWindow which opens the .qml file for this panel.
QML Changes:
2. window.qml shows initial menu - "Browse Map" and "Play Game"
3. GameOptions.qml file contains the game menu ( available games ).
4. GamesView.qml file contains a VisualItemModel which contains items CountryByShape and CountryByFlag ( for different types of
games ). This data is shown by a ListView.
5. CountryByShape.qml contains UI to be dislayed for "identify the country shape game" and similary CountryByFlag.qml for
"identify the flag" game.
6. CustomRadioButton.qml uses a RadioButtom item and provides some customizable properties like - buttonWidth, labelColor etc.
7. Similarly CustomButton.qml provides a Custom Button item.
C++ changes:
8. Refactored code and moved code for different types of games in separate files ( CountryByShape.cpp and CountryByFlag.cpp ).
I had almost no experince with qml and this is my second time I wrote qml code. So, there may be some design flaws. Please check the qml files.
ThankYou :)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added "identify the country shape" game.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
1. Game randomly highlights a country on political map.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
2. It displays random answer options out of which only one is correct. The user needs to check the button <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
displaying correct option.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here is a video showing the game http://youtu.be/kr0HsxLWXPs .</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The game needs the patch https://git.reviewboard.kde.org/r/118717/ to work.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works fine here :) .</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-game/GameMainWindow.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/GameMainWindow.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/GameOptions.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/GamesView.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/game.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/gamemain.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/marble.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/window.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/FileManager.h <span style="color: grey">(33de7cc)</span></li>
<li>src/apps/CMakeLists.txt <span style="color: grey">(022cd02)</span></li>
<li>src/apps/marble-game/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/CountryByFlag.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/CountryByFlag.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/CountryByFlag.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/CountryByShape.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/CountryByShape.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/CountryByShape.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/CustomButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-game/CustomRadioButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119264/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/14/d66172dc-0395-45a1-90de-403b411d1a5f__game.diff">game.diff</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>