[Marble-devel] Review Request 114876: [GCI] Fixed the checkbox regression in the Marble KDE version.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114876/#review46904
-----------------------------------------------------------


Dennis, which version of the patch do you prefer? The second one is very short but it leads to initTheme being executed twice on startup. The first one  is a bit more verbose but maybe the right thing to do ...

- Torsten Rahn


On Jan. 5, 2014, 11:43 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114876/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 11:43 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5786827474599936
> This regression was added with this commit: http://quickgit.kde.org/?p=marble.git&a=commit&h=fea987002a8a2cdf365455c55b8933328b3f10bd
> It happens because Legend widget is created after reading settings, so it doesn't update values of checkboxes.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleLegendBrowser.cpp 30e491f 
> 
> Diff: https://git.reviewboard.kde.org/r/114876/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140106/00b05ac5/attachment.html>