<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114876/">https://git.reviewboard.kde.org/r/114876/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dennis, which version of the patch do you prefer? The second one is very short but it leads to initTheme being executed twice on startup. The first one is a bit more verbose but maybe the right thing to do ...</pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On January 5th, 2014, 11:43 p.m. UTC, Mihail Ivchenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Mihail Ivchenko.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2014, 11:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5786827474599936
This regression was added with this commit: http://quickgit.kde.org/?p=marble.git&a=commit&h=fea987002a8a2cdf365455c55b8933328b3f10bd
It happens because Legend widget is created after reading settings, so it doesn't update values of checkboxes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleLegendBrowser.cpp <span style="color: grey">(30e491f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114876/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>