[Marble-devel] Review Request 114873: PackRunner plugin introduced

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Sun Jan 5 14:36:43 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114873/
-----------------------------------------------------------

(Updated Jan. 5, 2014, 4:36 p.m.)


Review request for Marble, Mihail Ivchenko, Dennis Nienhüser, and Torsten Rahn.


Repository: marble


Description
-------

According to Google Code-In 2013 task (https://www.google-melange.com/gci/task/view/google/gci2013/5860786811437056):

Ematirov's work and mine were merged to achieve the best practise of PackRunner plugin impl.


Diffs (updated)
-----

  src/plugins/runner/CMakeLists.txt 005f1b6 
  src/plugins/runner/pack/CMakeLists.txt PRE-CREATION 
  src/plugins/runner/pack/PackPlugin.h PRE-CREATION 
  src/plugins/runner/pack/PackPlugin.cpp PRE-CREATION 
  src/plugins/runner/pack/PackRunner.h PRE-CREATION 
  src/plugins/runner/pack/PackRunner.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114873/diff/


Testing
-------

Manual testing


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140105/74ab09aa/attachment.html>


More information about the Marble-devel mailing list