[Marble-devel] Review Request 114873: PackRunner plugin introduced

Mihail Ivchenko ematirov at gmail.com
Sun Jan 5 14:34:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114873/#review46851
-----------------------------------------------------------



src/plugins/runner/pack/PackPlugin.cpp
<https://git.reviewboard.kde.org/r/114873/#comment33444>

    Add me too please :)


- Mihail Ivchenko


On Jan. 5, 2014, 6:29 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114873/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 6:29 p.m.)
> 
> 
> Review request for Marble, Mihail Ivchenko, Dennis Nienhüser, and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (https://www.google-melange.com/gci/task/view/google/gci2013/5860786811437056):
> 
> Ematirov's work and mine were merged to achieve the best practise of PackRunner plugin impl.
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/CMakeLists.txt 005f1b6 
>   src/plugins/runner/pack/CMakeLists.txt PRE-CREATION 
>   src/plugins/runner/pack/PackPlugin.h PRE-CREATION 
>   src/plugins/runner/pack/PackPlugin.cpp PRE-CREATION 
>   src/plugins/runner/pack/PackRunner.h PRE-CREATION 
>   src/plugins/runner/pack/PackRunner.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/114873/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140105/39908410/attachment.html>


More information about the Marble-devel mailing list