[Marble-devel] Review Request 114867: Most foreach issues from Krazy fixed

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114867/#review46830
-----------------------------------------------------------


This review has been submitted with commit 552822ee78ab97477f5d9f0fc473adbc477e21fa by Illya Kovalevskyy to branch master.

- Commit Hook


On Jan. 4, 2014, 7:30 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114867/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2014, 7:30 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> According to Google Code-In 2013 task (https://www.google-melange.com/gci/task/view/google/gci2013/5345964114051072):
> 
> The issues reported by krazy in the section "Check for foreach loop issues" fixed, except a few cases in (Mobile/Qt)MainWindow.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleModel.cpp d3b3aed 
>   src/lib/marble/PlacemarkLayout.cpp 5b649ff 
>   src/lib/marble/TemplateDocument.cpp 18a28d1 
>   src/lib/marble/cloudsync/BookmarkSyncManager.cpp 43f93ad 
>   src/lib/marble/geodata/writers/dgml/DgmlTextureTagWriter.cpp 81e6c37 
>   src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp 6ab49af 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp ca080ef 
>   src/plugins/render/overviewmap/OverviewMap.cpp 8a1e3f4 
>   src/plugins/render/satellites/SatellitesPlugin.cpp 5645be4 
>   src/plugins/render/weather/WeatherPlugin.cpp 9e4dbf6 
>   src/plugins/runner/cyclestreets/CycleStreetsRunner.cpp 320635c 
> 
> Diff: https://git.reviewboard.kde.org/r/114867/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140104/3b430ec1/attachment.html>