<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114867/">https://git.reviewboard.kde.org/r/114867/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 552822ee78ab97477f5d9f0fc473adbc477e21fa by Illya Kovalevskyy to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 4th, 2014, 7:30 p.m. UTC, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2014, 7:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to Google Code-In 2013 task (https://www.google-melange.com/gci/task/view/google/gci2013/5345964114051072):
The issues reported by krazy in the section "Check for foreach loop issues" fixed, except a few cases in (Mobile/Qt)MainWindow.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleModel.cpp <span style="color: grey">(d3b3aed)</span></li>
<li>src/lib/marble/PlacemarkLayout.cpp <span style="color: grey">(5b649ff)</span></li>
<li>src/lib/marble/TemplateDocument.cpp <span style="color: grey">(18a28d1)</span></li>
<li>src/lib/marble/cloudsync/BookmarkSyncManager.cpp <span style="color: grey">(43f93ad)</span></li>
<li>src/lib/marble/geodata/writers/dgml/DgmlTextureTagWriter.cpp <span style="color: grey">(81e6c37)</span></li>
<li>src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp <span style="color: grey">(6ab49af)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp <span style="color: grey">(ca080ef)</span></li>
<li>src/plugins/render/overviewmap/OverviewMap.cpp <span style="color: grey">(8a1e3f4)</span></li>
<li>src/plugins/render/satellites/SatellitesPlugin.cpp <span style="color: grey">(5645be4)</span></li>
<li>src/plugins/render/weather/WeatherPlugin.cpp <span style="color: grey">(9e4dbf6)</span></li>
<li>src/plugins/runner/cyclestreets/CycleStreetsRunner.cpp <span style="color: grey">(320635c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114867/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>