[Marble-devel] Review Request 114854: Support worldwind URIs in Marble

[Levente Kurusa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114854/
-----------------------------------------------------------

Review request for Marble, Dennis Nienhüser and Torsten Rahn.


Repository: marble


Description
-------

This is a GCI task: https://www.google-melange.com/gci/task/view/google/gci2013/5784750857912320

It introduces a few new warnings, I didn't know what to do with them. :-)

/usr/src/marble/marble-3/src/lib/marble/GeoUriParser.cpp: In member function ‘bool Marble::GeoUriParser::parse()’:
/usr/src/marble/marble-3/src/lib/marble/GeoUriParser.cpp:110:16: warning: unused variable ‘bank’ [-Wunused-variable]
         double bank = getDoubleFromParameter(worldwindUrl, "bank", "");
                ^
/usr/src/marble/marble-3/src/lib/marble/GeoUriParser.cpp:111:16: warning: unused variable ‘dir’ [-Wunused-variable]
         double dir = getDoubleFromParameter(worldwindUrl, "dir", "direction");
                ^
/usr/src/marble/src/lib/marble/GeoUriParser.cpp:112:16: warning: unused variable ‘tilt’ [-Wunused-variable]
         double tilt = getDoubleFromParameter(worldwindUrl, "tilt", "");


Diffs
-----

  src/apps/marble-kde/CMakeLists.txt a39bf51 
  src/apps/marble-kde/kdemain.cpp 84c43d3 
  src/apps/marble-kde/marble_worldwind.desktop PRE-CREATION 
  src/apps/marble-qt/qtmain.cpp 26e1a03 
  src/lib/marble/GeoUriParser.h fc0a6ba 
  src/lib/marble/GeoUriParser.cpp de56e90 
  tests/GeoUriParserTest.cpp 44bd7de 

Diff: https://git.reviewboard.kde.org/r/114854/diff/


Testing
-------

Attached unit tests pass.


File Attachments
----------------

Konq opening worldwind:// uri
  https://git.reviewboard.kde.org/media/uploaded/files/2014/01/04/16b93c0e-ca78-4ec1-84e1-cdcb06af7394__geouriworking2.png


Thanks,

Levente Kurusa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140104/570bbd63/attachment.html>