<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114854/">https://git.reviewboard.kde.org/r/114854/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Levente Kurusa.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a GCI task: https://www.google-melange.com/gci/task/view/google/gci2013/5784750857912320
It introduces a few new warnings, I didn't know what to do with them. :-)
/usr/src/marble/marble-3/src/lib/marble/GeoUriParser.cpp: In member function ‘bool Marble::GeoUriParser::parse()’:
/usr/src/marble/marble-3/src/lib/marble/GeoUriParser.cpp:110:16: warning: unused variable ‘bank’ [-Wunused-variable]
double bank = getDoubleFromParameter(worldwindUrl, "bank", "");
^
/usr/src/marble/marble-3/src/lib/marble/GeoUriParser.cpp:111:16: warning: unused variable ‘dir’ [-Wunused-variable]
double dir = getDoubleFromParameter(worldwindUrl, "dir", "direction");
^
/usr/src/marble/src/lib/marble/GeoUriParser.cpp:112:16: warning: unused variable ‘tilt’ [-Wunused-variable]
double tilt = getDoubleFromParameter(worldwindUrl, "tilt", "");
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Attached unit tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-kde/CMakeLists.txt <span style="color: grey">(a39bf51)</span></li>
<li>src/apps/marble-kde/kdemain.cpp <span style="color: grey">(84c43d3)</span></li>
<li>src/apps/marble-kde/marble_worldwind.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-qt/qtmain.cpp <span style="color: grey">(26e1a03)</span></li>
<li>src/lib/marble/GeoUriParser.h <span style="color: grey">(fc0a6ba)</span></li>
<li>src/lib/marble/GeoUriParser.cpp <span style="color: grey">(de56e90)</span></li>
<li>tests/GeoUriParserTest.cpp <span style="color: grey">(44bd7de)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114854/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/01/04/16b93c0e-ca78-4ec1-84e1-cdcb06af7394__geouriworking2.png">Konq opening worldwind:// uri</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>