[Marble-devel] Review Request 114852: Mark constructors explicit

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114852/#review46767
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On Jan. 4, 2014, 1:04 p.m., Benjamin Kaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114852/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2014, 1:04 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Marked constructors explicit to address Krazy warnings 'explicit'.
> 
> The following two copy constructors have been excluded:
> TileCoordsPyramid( TileCoordsPyramid const & other );
> GeoDataLinearRing( const GeoDataGeometry &other );
> 
> 
> Diffs
> -----
> 
>   examples/cpp/vehicletracking/vehicletracking.h 544ab7e 
>   src/lib/marble/GeoUriParser.h fc0a6ba 
>   src/lib/marble/MarbleWebView.h cb994dd 
>   src/lib/marble/MergedLayerDecorator.h 422abb2 
>   src/lib/marble/TemplateDocument.h 3bca872 
>   src/lib/marble/TourPlayback.h dddde4d 
>   src/lib/marble/cloudsync/BookmarkSyncManager.h 8bb2ae5 
>   src/lib/marble/cloudsync/CloudRoutesDialog.h a449217 
>   src/lib/marble/cloudsync/ConflictDialog.h d1b7686 
>   src/lib/marble/cloudsync/OwncloudSyncBackend.h 5038f69 
>   src/lib/marble/cloudsync/RouteSyncManager.h c7a9f68 
>   src/lib/marble/geodata/data/GeoDataLineString_p.h 84e7c07 
>   src/lib/marble/geodata/data/GeoDataLinearRing_p.h ddd3ec0 
>   src/plugins/render/annotate/AreaAnnotation.h 62bbdbc 
>   src/plugins/render/satellites/TrackerPluginModel.h fcf6e87 
>   src/plugins/runner/local-osm-search/OsmDatabase.h ffbe4c7 
> 
> Diff: https://git.reviewboard.kde.org/r/114852/diff/
> 
> 
> Testing
> -------
> 
> > krazy2all --check explicit
> =>c++/explicit test in-progress......................................................................................................................................................................................................done
> 
> krazy2 Analysis
> 
> Checkers Run = 1
> Files Processed = 3176
> Total Issues = 2 ...as of January 04 2014 23:50:35 EST
> 
> == c++: For File Type c++ ==
> 1. Check for C++ ctors that should be declared 'explicit' [explicit]... 2 issues found
> 	./src/lib/astro/attlib.h: line#36,68 (2)
> 	./src/lib/marble/TileCoordsPyramid.h: line#27 (1)
> 	./src/lib/marble/geodata/data/GeoDataLinearRing.h: line#81 (1)
> 	Make all C++ class constructors that can be used with only one
> 	required argument 'explicit' to minimize wrong use of the class. Do
> 	this to avoid mistaken implicit constructor ambiguities. Copy
> 	constructors should not be explicit.
> 
> 
> Thanks,
> 
> Benjamin Kaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140104/2073193c/attachment.html>