<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114852/">https://git.reviewboard.kde.org/r/114852/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On January 4th, 2014, 1:04 p.m. UTC, Benjamin Kaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Benjamin Kaiser.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2014, 1:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marked constructors explicit to address Krazy warnings 'explicit'.
The following two copy constructors have been excluded:
TileCoordsPyramid( TileCoordsPyramid const & other );
GeoDataLinearRing( const GeoDataGeometry &other );</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> krazy2all --check explicit
=>c++/explicit test in-progress......................................................................................................................................................................................................done
krazy2 Analysis
Checkers Run = 1
Files Processed = 3176
Total Issues = 2 ...as of January 04 2014 23:50:35 EST
== c++: For File Type c++ ==
1. Check for C++ ctors that should be declared 'explicit' [explicit]... 2 issues found
./src/lib/astro/attlib.h: line#36,68 (2)
./src/lib/marble/TileCoordsPyramid.h: line#27 (1)
./src/lib/marble/geodata/data/GeoDataLinearRing.h: line#81 (1)
Make all C++ class constructors that can be used with only one
required argument 'explicit' to minimize wrong use of the class. Do
this to avoid mistaken implicit constructor ambiguities. Copy
constructors should not be explicit.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>examples/cpp/vehicletracking/vehicletracking.h <span style="color: grey">(544ab7e)</span></li>
<li>src/lib/marble/GeoUriParser.h <span style="color: grey">(fc0a6ba)</span></li>
<li>src/lib/marble/MarbleWebView.h <span style="color: grey">(cb994dd)</span></li>
<li>src/lib/marble/MergedLayerDecorator.h <span style="color: grey">(422abb2)</span></li>
<li>src/lib/marble/TemplateDocument.h <span style="color: grey">(3bca872)</span></li>
<li>src/lib/marble/TourPlayback.h <span style="color: grey">(dddde4d)</span></li>
<li>src/lib/marble/cloudsync/BookmarkSyncManager.h <span style="color: grey">(8bb2ae5)</span></li>
<li>src/lib/marble/cloudsync/CloudRoutesDialog.h <span style="color: grey">(a449217)</span></li>
<li>src/lib/marble/cloudsync/ConflictDialog.h <span style="color: grey">(d1b7686)</span></li>
<li>src/lib/marble/cloudsync/OwncloudSyncBackend.h <span style="color: grey">(5038f69)</span></li>
<li>src/lib/marble/cloudsync/RouteSyncManager.h <span style="color: grey">(c7a9f68)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLineString_p.h <span style="color: grey">(84e7c07)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLinearRing_p.h <span style="color: grey">(ddd3ec0)</span></li>
<li>src/plugins/render/annotate/AreaAnnotation.h <span style="color: grey">(62bbdbc)</span></li>
<li>src/plugins/render/satellites/TrackerPluginModel.h <span style="color: grey">(fcf6e87)</span></li>
<li>src/plugins/runner/local-osm-search/OsmDatabase.h <span style="color: grey">(ffbe4c7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114852/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>