[Marble-devel] Review Request 114848: Fix QString doublequote_chars issues

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114848/#review46758
-----------------------------------------------------------


This review has been submitted with commit 661867d90355c22e40c5385c3c0da9ce54984747 by Benjamin Kaiser to branch master.

- Commit Hook


On Jan. 4, 2014, 11:04 a.m., Benjamin Kaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114848/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2014, 11:04 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Fix QString doublequote_chars issues as found by krazy.
> 
> The file /src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp has been left unchanged. Dennis confirmed this was okay.
> 
> Krazy report: http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/marble/index.html
> GCI Task: http://www.google-melange.com/gci/task/view/google/gci2013/5228673925906432
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MapThemeDownloadDialog.cpp 6a527a5 
>   src/lib/marble/MapViewWidget.cpp 3450f71 
>   src/lib/marble/MarbleLegendBrowser.cpp 644dd0f 
>   src/lib/marble/MarbleWidgetPopupMenu.cpp e527bdf 
>   src/lib/marble/MovieCapture.cpp 83b5c3e 
>   src/lib/marble/MovieCaptureDialog.cpp 6e80d89 
>   src/lib/marble/TemplateDocument.cpp 18a28d1 
>   src/lib/marble/cloudsync/BookmarkSyncManager.cpp 43f93ad 
>   src/lib/marble/cloudsync/OwncloudSyncBackend.cpp 889522e 
>   src/lib/marble/cloudsync/RouteItemDelegate.cpp fc29a6a 
>   src/lib/marble/cloudsync/RouteSyncManager.cpp c873ff1 
>   src/plugins/render/opencachingcom/OpenCachingComItem.cpp d332c53 
>   src/plugins/render/photo/PhotoPlugin.cpp acc7191 
>   src/plugins/render/stars/StarsPlugin.cpp 51a2b65 
>   src/plugins/runner/cyclestreets/CycleStreetsRunner.cpp 320635c 
>   src/plugins/runner/kml/KmzHandler.cpp c20754f 
>   tools/constellations2kml/constellations2kml.cpp a32d1f2 
> 
> Diff: https://git.reviewboard.kde.org/r/114848/diff/
> 
> 
> Testing
> -------
> 
> $ krazy2all --check doublequote_chars
> =>c++/doublequote_chars test in-progress......................................................................................................................................................................................................done
> 
> krazy2 Analysis
> 
> Checkers Run = 1
> Files Processed = 3176
> Total Issues = 5 ...as of January 04 2014 21:55:49 EST
> 
> == c++: For File Type c++ ==
> 1. Check single-char QString operations for efficiency [doublequote_chars]... 5 issues found
> 	./src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp: line#80,198,202,203,204 (5)
> 	Adding single characters to a QString is faster if the characters
> 	are QChars and not QStrings.  For example: QString path = oldpath +
> 	"/" + base is better written as QString path = oldpath + '/' +
> 	base. Same holds for arguments to QString::startsWith(),
> 	QString::endsWith(), QString::remove(), QString::section(), and
> 	QString::split(). Use QString::remove() instead of
> 	QString::replace(foo,"")
> 
> 
> Thanks,
> 
> Benjamin Kaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140104/77c9326d/attachment-0001.html>