<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114848/">https://git.reviewboard.kde.org/r/114848/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 661867d90355c22e40c5385c3c0da9ce54984747 by Benjamin Kaiser to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 4th, 2014, 11:04 a.m. UTC, Benjamin Kaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Benjamin Kaiser.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2014, 11:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix QString doublequote_chars issues as found by krazy.
The file /src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp has been left unchanged. Dennis confirmed this was okay.
Krazy report: http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/marble/index.html
GCI Task: http://www.google-melange.com/gci/task/view/google/gci2013/5228673925906432</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">$ krazy2all --check doublequote_chars
=>c++/doublequote_chars test in-progress......................................................................................................................................................................................................done
krazy2 Analysis
Checkers Run = 1
Files Processed = 3176
Total Issues = 5 ...as of January 04 2014 21:55:49 EST
== c++: For File Type c++ ==
1. Check single-char QString operations for efficiency [doublequote_chars]... 5 issues found
./src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp: line#80,198,202,203,204 (5)
Adding single characters to a QString is faster if the characters
are QChars and not QStrings. For example: QString path = oldpath +
"/" + base is better written as QString path = oldpath + '/' +
base. Same holds for arguments to QString::startsWith(),
QString::endsWith(), QString::remove(), QString::section(), and
QString::split(). Use QString::remove() instead of
QString::replace(foo,"")
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MapThemeDownloadDialog.cpp <span style="color: grey">(6a527a5)</span></li>
<li>src/lib/marble/MapViewWidget.cpp <span style="color: grey">(3450f71)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.cpp <span style="color: grey">(644dd0f)</span></li>
<li>src/lib/marble/MarbleWidgetPopupMenu.cpp <span style="color: grey">(e527bdf)</span></li>
<li>src/lib/marble/MovieCapture.cpp <span style="color: grey">(83b5c3e)</span></li>
<li>src/lib/marble/MovieCaptureDialog.cpp <span style="color: grey">(6e80d89)</span></li>
<li>src/lib/marble/TemplateDocument.cpp <span style="color: grey">(18a28d1)</span></li>
<li>src/lib/marble/cloudsync/BookmarkSyncManager.cpp <span style="color: grey">(43f93ad)</span></li>
<li>src/lib/marble/cloudsync/OwncloudSyncBackend.cpp <span style="color: grey">(889522e)</span></li>
<li>src/lib/marble/cloudsync/RouteItemDelegate.cpp <span style="color: grey">(fc29a6a)</span></li>
<li>src/lib/marble/cloudsync/RouteSyncManager.cpp <span style="color: grey">(c873ff1)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComItem.cpp <span style="color: grey">(d332c53)</span></li>
<li>src/plugins/render/photo/PhotoPlugin.cpp <span style="color: grey">(acc7191)</span></li>
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(51a2b65)</span></li>
<li>src/plugins/runner/cyclestreets/CycleStreetsRunner.cpp <span style="color: grey">(320635c)</span></li>
<li>src/plugins/runner/kml/KmzHandler.cpp <span style="color: grey">(c20754f)</span></li>
<li>tools/constellations2kml/constellations2kml.cpp <span style="color: grey">(a32d1f2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114848/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>