[Marble-devel] Review Request 110005: Deprecate VectorComposer

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110005/
-----------------------------------------------------------

(Updated Jan. 3, 2014, 7:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Repository: marble


Description
-------

Uses the GeoData model and rendering instead of the legacy Vector code.
Removed Classes are:
- GeoPolygon
- ScreenPolygon
- VectorComposer
- VectorMap
- VectorMapBaseLayer and
- VectorMapLayer


Diffs
-----

  data/maps/earth/bluemarble/bluemarble.dgml 4e40406 
  data/maps/earth/citylights/citylights.dgml 8b72b60 
  data/maps/earth/plain/plain.dgml 0e329c0 
  data/maps/earth/precip-dec/precip-dec.dgml 77f38cf 
  data/maps/earth/precip-july/precip-july.dgml f9e93f5 
  data/maps/earth/schagen1689/schagen1689.dgml c68415c 
  data/maps/earth/srtm/srtm.dgml d5b9810 
  data/maps/earth/temp-dec/temp-dec.dgml 4d62d72 
  data/maps/earth/temp-july/temp-july.dgml 394cb0e 
  data/maps/sky/nightsky/nightsky.dgml f0d3777 
  src/lib/CMakeLists.txt 534a7a9 
  src/lib/GeoPolygon.h 37fb401 
  src/lib/GeoPolygon.cpp ba9da66 
  src/lib/MarbleMap.cpp 14ccd36 
  src/lib/MarbleModel.cpp 5df138a 
  src/lib/ScreenPolygon.h a1001d5 
  src/lib/TextureColorizer.h 1fc2638 
  src/lib/TextureColorizer.cpp f372830 
  src/lib/VectorComposer.h b20db7c 
  src/lib/VectorComposer.cpp 4d9600c 
  src/lib/VectorMap.h 41a2e16 
  src/lib/VectorMap.cpp cf3dcef 
  src/lib/geodata/handlers/dgml/DgmlBrushTagHandler.cpp 50ce419 
  src/lib/geodata/handlers/dgml/DgmlPenTagHandler.cpp 687ab61 
  src/lib/geodata/handlers/dgml/DgmlSourceFileTagHandler.cpp f7c007f 
  src/lib/geodata/handlers/dgml/DgmlVectorTagHandler.cpp b05ad8f 
  src/lib/layers/CMakeLists.txt 4efe657 
  src/lib/layers/TextureLayer.h 7c5f16c 
  src/lib/layers/TextureLayer.cpp 1fe50d8 
  src/lib/layers/VectorMapBaseLayer.h 4934cb9 
  src/lib/layers/VectorMapBaseLayer.cpp 1bf1fbd 
  src/lib/layers/VectorMapLayer.h 14e168d 
  src/lib/layers/VectorMapLayer.cpp f05c88a 
  tests/CMakeLists.txt d4cfec5 
  tests/GeoPolygonTest.cpp 1f68f84 

Diff: https://git.reviewboard.kde.org/r/110005/diff/


Testing
-------

Existing dgml files have been ported to still use <vector> tag if doable, otherwise to directly use <geodata>
All themes work, legend properties are functionnal still


Thanks,

Thibaut Gridel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140103/5464e6e3/attachment.html>