[Marble-devel] Review Request 114761: Add support for ListStyle::ItemIcon::href

Levente Kurusa levex at linux.com
Wed Jan 1 10:48:25 UTC 2014



> On Jan. 1, 2014, 8:10 a.m., Dennis Nienhüser wrote:
> > src/lib/marble/GeoDataTreeModel.cpp, line 324
> > <https://git.reviewboard.kde.org/r/114761/diff/1/?file=228507#file228507line324>
> >
> >     Shouldn't this iterate over all styles and select the one which has a suitable state?
> >

Yes, it should, but we can't find out the requested item's state yet...


- Levente


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114761/#review46525
-----------------------------------------------------------


On Dec. 31, 2013, 3:35 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114761/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2013, 3:35 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/6070288135487488
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/GeoDataTreeModel.cpp 9f9cc0a 
>   src/lib/marble/geodata/data/GeoDataItemIcon.cpp d731a11 
>   src/lib/marble/geodata/data/GeoDataStyle.cpp 8771787 
> 
> Diff: https://git.reviewboard.kde.org/r/114761/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140101/d6235efa/attachment.html>


More information about the Marble-devel mailing list