[Marble-devel] Review Request 114761: Add support for ListStyle::ItemIcon::href

Dennis Nienhüser earthwings at gentoo.org
Wed Jan 1 08:10:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114761/#review46525
-----------------------------------------------------------



src/lib/marble/GeoDataTreeModel.cpp
<https://git.reviewboard.kde.org/r/114761/#comment33221>

    Shouldn't this iterate over all styles and select the one which has a suitable state?
    


- Dennis Nienhüser


On Dec. 31, 2013, 3:35 p.m., Levente Kurusa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114761/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2013, 3:35 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/6070288135487488
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/GeoDataTreeModel.cpp 9f9cc0a 
>   src/lib/marble/geodata/data/GeoDataItemIcon.cpp d731a11 
>   src/lib/marble/geodata/data/GeoDataStyle.cpp 8771787 
> 
> Diff: https://git.reviewboard.kde.org/r/114761/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Levente Kurusa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140101/848e0d19/attachment.html>


More information about the Marble-devel mailing list