[Marble-devel] Review Request 116463: Changes GeoDataObject id and targetId from int to QString

[Dennis Nienhüser]

> On Feb. 28, 2014, 6:06 a.m., Dennis Nienhüser wrote:
> > tests/TestGeoDataCopy.cpp, line 415
> > <https://git.reviewboard.kde.org/r/116463/diff/1/?file=250938#file250938line415>
> >
> >     "281012"
> 
> Sanjiban Bairagya wrote:
>     "281012" is giving error, whereas QString(281012) is not

Here that one works, but the QCOMPARE ones below want an explicit QString("281012") because they don't like an implicit conversion from const char* to QString. QString(281012) however will construct something strange. I fixed it in the committed version.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116463/#review51290
-----------------------------------------------------------


On Feb. 28, 2014, 8:26 a.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116463/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 8:26 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331585
>     http://bugs.kde.org/show_bug.cgi?id=331585
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Changed the id and targetId members of the GeoDataObject class from int to QString. Changed the corresponding getters/setters accordingly.
> Adjusted PopupLayer.cpp by changing QString::number(placemark->id()) to a simple placemark->id().
> Removed the id member from the following classes: GeoDataTourControl, GeoDataTour, GeoDataWait, GeoDataSoundCue.
> Made a few adjustments with TestGeoDataCopy
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataObject.h ac29c8b 
>   src/lib/marble/geodata/data/GeoDataObject.cpp 736b790 
>   src/lib/marble/geodata/data/GeoDataSoundCue.h 3e2c67d 
>   src/lib/marble/geodata/data/GeoDataSoundCue.cpp 9f93c57 
>   src/lib/marble/geodata/data/GeoDataTour.h 1b04904 
>   src/lib/marble/geodata/data/GeoDataTour.cpp 4a8a4ca 
>   src/lib/marble/geodata/data/GeoDataTourControl.h 19c360f 
>   src/lib/marble/geodata/data/GeoDataTourControl.cpp 96c1c9a 
>   src/lib/marble/geodata/data/GeoDataWait.h abe1480 
>   src/lib/marble/geodata/data/GeoDataWait.cpp 8d71c09 
>   src/lib/marble/layers/PopupLayer.cpp bb5eb21 
>   tests/TestGeoDataCopy.cpp 7ae8e48 
> 
> Diff: https://git.reviewboard.kde.org/r/116463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140228/89aaa993/attachment.html>