[Marble-devel] Review Request 116463: Changes GeoDataObject id and targetId from int to QString

[Sanjiban Bairagya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116463/
-----------------------------------------------------------

(Updated Feb. 28, 2014, 7:12 a.m.)


Review request for Marble.


Changes
-------

Fixed a few issues


Bugs: 331585
    http://bugs.kde.org/show_bug.cgi?id=331585


Repository: marble


Description
-------

Changed the id and targetId members of the GeoDataObject class from int to QString. Changed the corresponding getters/setters accordingly.
Adjusted PopupLayer.cpp by changing QString::number(placemark->id()) to a simple placemark->id().
Removed the id member from the following classes: GeoDataTourControl, GeoDataTour, GeoDataWait, GeoDataSoundCue.
Made a few adjustments with TestGeoDataCopy


Diffs (updated)
-----

  src/lib/marble/geodata/data/GeoDataObject.h ac29c8b 
  src/lib/marble/geodata/data/GeoDataObject.cpp 736b790 
  src/lib/marble/geodata/data/GeoDataSoundCue.h 3e2c67d 
  src/lib/marble/geodata/data/GeoDataSoundCue.cpp 9f93c57 
  src/lib/marble/geodata/data/GeoDataTour.h 1b04904 
  src/lib/marble/geodata/data/GeoDataTour.cpp 4a8a4ca 
  src/lib/marble/geodata/data/GeoDataTourControl.h 19c360f 
  src/lib/marble/geodata/data/GeoDataTourControl.cpp 96c1c9a 
  src/lib/marble/geodata/data/GeoDataWait.h abe1480 
  src/lib/marble/geodata/data/GeoDataWait.cpp 8d71c09 
  src/lib/marble/layers/PopupLayer.cpp bb5eb21 
  tests/TestGeoDataCopy.cpp 7ae8e48 

Diff: https://git.reviewboard.kde.org/r/116463/diff/


Testing
-------


Thanks,

Sanjiban Bairagya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140228/bebb5075/attachment.html>