[Marble-devel] Review Request 116110: Implement equality operators for GeoDataBalloonStyle, GeoDataColorStyle and GeoDataCamera

Cruceru Calin-Cristian crucerucalincristian at gmail.com
Thu Feb 27 21:16:00 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116110/
-----------------------------------------------------------

(Updated Feb. 27, 2014, 9:16 p.m.)


Review request for Marble.


Changes
-------

Updated so it can be applied to master branch.


Bugs: 331525
    http://bugs.kde.org/show_bug.cgi?id=331525


Repository: marble


Description
-------

Adds operator== and operator!= to each of the classes GeoDataBalloonStyle, GeoDataColorStyle and GeoDataCamera.
Extends tests/TestEquality by a new unit test method for each of the classes which verifies the implementation for several instances of each class. 


Diffs (updated)
-----

  src/lib/marble/geodata/data/GeoDataBalloonStyle.h 5b2964d 
  src/lib/marble/geodata/data/GeoDataBalloonStyle.cpp ae761cc 
  src/lib/marble/geodata/data/GeoDataCamera.h bdcc196 
  src/lib/marble/geodata/data/GeoDataCamera.cpp eb24060 
  src/lib/marble/geodata/data/GeoDataColorStyle.h d50ff30 
  src/lib/marble/geodata/data/GeoDataColorStyle.cpp 6e6ead7 
  tests/TestEquality.cpp fe668a6 

Diff: https://git.reviewboard.kde.org/r/116110/diff/


Testing
-------


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140227/2674803c/attachment-0001.html>


More information about the Marble-devel mailing list