[Marble-devel] Review Request 116110: Implement equality operators for GeoDataBalloonStyle, GeoDataColorStyle and GeoDataCamera

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116110/#review51130
-----------------------------------------------------------

Ship it!


Looks good to me.

- Torsten Rahn


On Feb. 27, 2014, 12:28 a.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116110/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 12:28 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331525
>     http://bugs.kde.org/show_bug.cgi?id=331525
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Adds operator== and operator!= to each of the classes GeoDataBalloonStyle, GeoDataColorStyle and GeoDataCamera.
> Extends tests/TestEquality by a new unit test method for each of the classes which verifies the implementation for several instances of each class. 
> 
> 
> Diffs
> -----
> 
>   tests/TestEquality.cpp 8884fef 
> 
> Diff: https://git.reviewboard.kde.org/r/116110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140227/5b26bd3a/attachment.html>