[Marble-devel] Review Request 116045: Simplifies the ScreenOverlay unit test

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116045/#review50854
-----------------------------------------------------------



src/lib/marble/geodata/writers/kml/KmlScreenOverlayWriter.cpp
<https://git.reviewboard.kde.org/r/116045/#comment35705>

    This needs to be kept, it writes other important elements.
    



src/lib/marble/geodata/writers/kml/KmlScreenOverlayWriter.cpp
<https://git.reviewboard.kde.org/r/116045/#comment35698>

    This is already done in KmlOverlayTagWriter::writeMid(), so not needed.



src/lib/marble/geodata/writers/kml/KmlScreenOverlayWriter.cpp
<https://git.reviewboard.kde.org/r/116045/#comment35700>

    Good catch :)



tests/data/ScreenOverlay_Folder.kml
<https://git.reviewboard.kde.org/r/116045/#comment35706>

    Move this on top of the <overlayXY... line and the test will succeed even with the changes above. This works around a shortcoming in TestGeoDataWriter. Soon (when the operator== tasks are done) we can write more advanced tests that don't need such hacks.
    



tests/data/ScreenOverlay_kml.kml
<https://git.reviewboard.kde.org/r/116045/#comment35707>

    Move further up as noted in the comment above.


- Dennis Nienhüser


On Feb. 25, 2014, 12:33 p.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116045/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 12:33 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331469
>     http://bugs.kde.org/show_bug.cgi?id=331469
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Moves the inline KML file defined in TestScreenOverlay::simpleParseTest() to a new file tests/data/ScreenOverlay_Folder.kml.
> Adds a ScreenOverlay to ScreenOverlay_kml.kml where the ScreenOverlay tag is a direct child of the kml tag (not inside a folder).
> Adds these kml files to TestGeoDataWriter and removes TestScreenOverlay.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/writers/kml/KmlScreenOverlayWriter.cpp 5542101 
>   tests/CMakeLists.txt a6dad0c 
>   tests/TestGeoDataWriter.cpp f4f7467 
>   tests/TestScreenOverlay.cpp e3e36a1 
>   tests/data/ScreenOverlay_Folder.kml PRE-CREATION 
>   tests/data/ScreenOverlay_kml.kml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116045/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140225/b9364d09/attachment-0001.html>