[Marble-devel] Review Request 116045: Simplifies the ScreenOverlay unit test

Sanjiban Bairagya sanjiban22393 at gmail.com
Tue Feb 25 12:33:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116045/
-----------------------------------------------------------

Review request for Marble.


Bugs: 331469
    http://bugs.kde.org/show_bug.cgi?id=331469


Repository: marble


Description
-------

Moves the inline KML file defined in TestScreenOverlay::simpleParseTest() to a new file tests/data/ScreenOverlay_Folder.kml.
Adds a ScreenOverlay to ScreenOverlay_kml.kml where the ScreenOverlay tag is a direct child of the kml tag (not inside a folder).
Adds these kml files to TestGeoDataWriter and removes TestScreenOverlay.


Diffs
-----

  src/lib/marble/geodata/writers/kml/KmlScreenOverlayWriter.cpp 5542101 
  tests/CMakeLists.txt a6dad0c 
  tests/TestGeoDataWriter.cpp f4f7467 
  tests/TestScreenOverlay.cpp e3e36a1 
  tests/data/ScreenOverlay_Folder.kml PRE-CREATION 
  tests/data/ScreenOverlay_kml.kml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116045/diff/


Testing
-------


Thanks,

Sanjiban Bairagya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140225/c04b9c51/attachment.html>


More information about the Marble-devel mailing list