[Marble-devel] Review Request 121487: Removing char* assignments from headers

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121487/#review72008
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Dez. 14, 2014, 9:51 nachm., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121487/
> -----------------------------------------------------------
> 
> (Updated Dez. 14, 2014, 9:51 nachm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Bugs: 341203
>     http://bugs.kde.org/show_bug.cgi?id=341203
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> As described in related bug (http://bugs.kde.org/show_bug.cgi?id=341203), in case if your application, which includes Marble headers, also define QT_NO_CAST_ASCII, it won't get built. For instance, KF5 use QT_NO_CAST_ASCII by default, so we should use QLatin1String, instead of char* in all public headers.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/AbstractDataPlugin.h 1a85f7d 
>   src/lib/marble/AbstractFloatItem.h 6060c2e 
>   src/lib/marble/MapWizard.h 291f022 
>   src/lib/marble/MarbleModel.h 7bc3e73 
>   src/lib/marble/layers/FogLayer.h 5bf4868 
>   src/lib/marble/layers/GeometryLayer.h e32b520 
>   src/lib/marble/layers/GroundLayer.h 2e6eee6 
>   src/lib/marble/layers/MarbleSplashLayer.h 71e101b 
>   src/lib/marble/layers/PlacemarkLayer.h cbe5636 
>   src/lib/marble/layers/TextureLayer.h 8f2be24 
>   src/lib/marble/layers/VectorTileLayer.h b00d348 
> 
> Diff: https://git.reviewboard.kde.org/r/121487/diff/
> 
> 
> Testing
> -------
> 
> Built & run
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141214/8260a915/attachment.html>