<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121487/">https://git.reviewboard.kde.org/r/121487/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On Dezember 14th, 2014, 9:51 nachm. UTC, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Dez. 14, 2014, 9:51 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=341203">341203</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As described in related bug (http://bugs.kde.org/show_bug.cgi?id=341203), in case if your application, which includes Marble headers, also define QT_NO_CAST_ASCII, it won't get built. For instance, KF5 use QT_NO_CAST_ASCII by default, so we should use QLatin1String, instead of char* in all public headers.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built & run</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/AbstractDataPlugin.h <span style="color: grey">(1a85f7d)</span></li>
<li>src/lib/marble/AbstractFloatItem.h <span style="color: grey">(6060c2e)</span></li>
<li>src/lib/marble/MapWizard.h <span style="color: grey">(291f022)</span></li>
<li>src/lib/marble/MarbleModel.h <span style="color: grey">(7bc3e73)</span></li>
<li>src/lib/marble/layers/FogLayer.h <span style="color: grey">(5bf4868)</span></li>
<li>src/lib/marble/layers/GeometryLayer.h <span style="color: grey">(e32b520)</span></li>
<li>src/lib/marble/layers/GroundLayer.h <span style="color: grey">(2e6eee6)</span></li>
<li>src/lib/marble/layers/MarbleSplashLayer.h <span style="color: grey">(71e101b)</span></li>
<li>src/lib/marble/layers/PlacemarkLayer.h <span style="color: grey">(cbe5636)</span></li>
<li>src/lib/marble/layers/TextureLayer.h <span style="color: grey">(8f2be24)</span></li>
<li>src/lib/marble/layers/VectorTileLayer.h <span style="color: grey">(b00d348)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121487/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>