[Marble-devel] Review Request 119649: Gnomonic projection, created by Bernhard Beschow

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119649/#review65554
-----------------------------------------------------------



src/lib/marble/GnomonicScanlineTextureMapper.cpp
<https://git.reviewboard.kde.org/r/119649/#comment45809>

    Nope, we don't want to save this ;)



src/lib/marble/projections/GnomonicProjection.cpp
<https://git.reviewboard.kde.org/r/119649/#comment45812>

    This will lead to faulty rendering if cosC is close to 0 and the division in line 121 and 122 will divide almost by zero - or worse by zero!



src/lib/marble/projections/GnomonicProjection.cpp
<https://git.reviewboard.kde.org/r/119649/#comment45810>

    Atan2 must be used here - otherwise rendering is faulty.



src/lib/marble/projections/GnomonicProjection.cpp
<https://git.reviewboard.kde.org/r/119649/#comment45811>

    This one just reuses the spherical code - however we need some horizon for this projection introduced here to avoid artefacts.


- Torsten Rahn


On Aug. 20, 2014, 1:04 nachm., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119649/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 1:04 nachm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch contains the the support for gnomonic projection.
> 
> Created by Bernhard Beschow.
> 
> Origin: https://github.com/shentok/marble/tree/streetview
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/CMakeLists.txt 532ec3d3e63bd78e06600f0c11a2ee653f56a721 
>   src/lib/marble/GnomonicScanlineTextureMapper.h PRE-CREATION 
>   src/lib/marble/GnomonicScanlineTextureMapper.cpp PRE-CREATION 
>   src/lib/marble/MapViewWidget.h 9a86c1e5d06df2a1ed44eab8f10544cf3b8acc7e 
>   src/lib/marble/MapViewWidget.cpp b55dc1cfbf5caa7d44846bedaf048648009a6076 
>   src/lib/marble/MarbleGlobal.h 69a96f3badc69edc36a0163a173f7214fe71aeb5 
>   src/lib/marble/ViewportParams.cpp d6cf03603b353671f52440adcea15ddecf188b94 
>   src/lib/marble/layers/TextureLayer.cpp 845b032c7b7603af5af0bdb9064b01e0a0817af3 
>   src/lib/marble/projections/AzimuthalProjection.h PRE-CREATION 
>   src/lib/marble/projections/AzimuthalProjection.cpp PRE-CREATION 
>   src/lib/marble/projections/AzimuthalProjection_p.h PRE-CREATION 
>   src/lib/marble/projections/GnomonicProjection.h PRE-CREATION 
>   src/lib/marble/projections/GnomonicProjection.cpp PRE-CREATION 
>   src/plugins/declarative/MarbleDeclarativeWidget.cpp 0cb6c94d584f385317caa8e88f19fbfec57a5a95 
>   src/lib/marble/projections/SphericalProjection.h 865407da4e67a6bcdc07fb7bb83ab5f4e7ab7a20 
>   src/lib/marble/projections/SphericalProjection.cpp 669851ee72d89a128814de8e7575d6db4ce5db15 
> 
> Diff: https://git.reviewboard.kde.org/r/119649/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140830/a4e25b97/attachment-0001.html>