<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119649/">https://git.reviewboard.kde.org/r/119649/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119649/diff/5/?file=306608#file306608line97" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/GnomonicScanlineTextureMapper.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">97</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_canvasImage</span><span class="p">.</span><span class="n">save</span><span class="p">(</span><span class="s">"/home/gobormano/imageeeeeebef.jpg"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nope, we don't want to save this ;)</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119649/diff/5/?file=306618#file306618line119" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/projections/GnomonicProjection.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">119</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">qreal</span> <span class="n">cosC</span> <span class="o">=</span> <span class="n">qSin</span><span class="p">(</span> <span class="n">phi1</span> <span class="p">)</span> <span class="o">*</span> <span class="n">qSin</span><span class="p">(</span> <span class="n">phi</span> <span class="p">)</span> <span class="o">+</span> <span class="n">qCos</span><span class="p">(</span> <span class="n">phi1</span> <span class="p">)</span> <span class="o">*</span> <span class="n">qCos</span><span class="p">(</span> <span class="n">phi</span> <span class="p">)</span> <span class="o">*</span> <span class="n">qCos</span><span class="p">(</span> <span class="n">lambda</span> <span class="o">-</span> <span class="n">lambdaPrime</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This will lead to faulty rendering if cosC is close to 0 and the division in line 121 and 122 will divide almost by zero - or worse by zero!</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119649/diff/5/?file=306618#file306618line179" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/projections/GnomonicProjection.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">179</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">lon</span> <span class="o">=</span> <span class="n">centerLon</span> <span class="o">+</span> <span class="n">qAtan</span><span class="p">(</span> <span class="n">rx</span><span class="o">*</span><span class="n">qSin</span><span class="p">(</span><span class="n">c</span><span class="p">)</span> <span class="o">/</span> <span class="p">(</span> <span class="n">p</span><span class="o">*</span><span class="n">qCos</span><span class="p">(</span> <span class="n">centerLat</span> <span class="p">)</span><span class="o">*</span><span class="n">qCos</span><span class="p">(</span> <span class="n">c</span> <span class="p">)</span> <span class="o">-</span> <span class="n">ry</span><span class="o">*</span><span class="n">qSin</span><span class="p">(</span> <span class="n">centerLat</span> <span class="p">)</span><span class="o">*</span><span class="n">qSin</span><span class="p">(</span> <span class="n">c</span> <span class="p">)</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Atan2 must be used here - otherwise rendering is faulty.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119649/diff/5/?file=306618#file306618line682" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/projections/GnomonicProjection.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">682</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qreal</span> <span class="n">absoluteAltitude</span> <span class="o">=</span> <span class="n">coordinates</span><span class="p">.</span><span class="n">altitude</span><span class="p">()</span> <span class="o">+</span> <span class="n">EARTH_RADIUS</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This one just reuses the spherical code - however we need some horizon for this projection introduced here to avoid artefacts.</p></pre>
</div>
</div>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On August 20th, 2014, 1:04 nachm. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2014, 1:04 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch contains the the support for gnomonic projection.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Created by Bernhard Beschow.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Origin: https://github.com/shentok/marble/tree/streetview</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(532ec3d3e63bd78e06600f0c11a2ee653f56a721)</span></li>
<li>src/lib/marble/GnomonicScanlineTextureMapper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/GnomonicScanlineTextureMapper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/MapViewWidget.h <span style="color: grey">(9a86c1e5d06df2a1ed44eab8f10544cf3b8acc7e)</span></li>
<li>src/lib/marble/MapViewWidget.cpp <span style="color: grey">(b55dc1cfbf5caa7d44846bedaf048648009a6076)</span></li>
<li>src/lib/marble/MarbleGlobal.h <span style="color: grey">(69a96f3badc69edc36a0163a173f7214fe71aeb5)</span></li>
<li>src/lib/marble/ViewportParams.cpp <span style="color: grey">(d6cf03603b353671f52440adcea15ddecf188b94)</span></li>
<li>src/lib/marble/layers/TextureLayer.cpp <span style="color: grey">(845b032c7b7603af5af0bdb9064b01e0a0817af3)</span></li>
<li>src/lib/marble/projections/AzimuthalProjection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/AzimuthalProjection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/AzimuthalProjection_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/GnomonicProjection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/projections/GnomonicProjection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/declarative/MarbleDeclarativeWidget.cpp <span style="color: grey">(0cb6c94d584f385317caa8e88f19fbfec57a5a95)</span></li>
<li>src/lib/marble/projections/SphericalProjection.h <span style="color: grey">(865407da4e67a6bcdc07fb7bb83ab5f4e7ab7a20)</span></li>
<li>src/lib/marble/projections/SphericalProjection.cpp <span style="color: grey">(669851ee72d89a128814de8e7575d6db4ce5db15)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119649/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>