[Marble-devel] Review Request 119700: Allow cancelling tour recording, and clean up properly in that case
Dennis Nienhüser
earthwings at gentoo.org
Mon Aug 11 17:22:14 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119700/#review64283
-----------------------------------------------------------
Ship it!
src/lib/marble/MovieCapture.cpp
<https://git.reviewboard.kde.org/r/119700/#comment44930>
Please change to `mDebug()` while we're at it
- Dennis Nienhüser
On Aug. 11, 2014, 9:10 a.m., Sanjiban Bairagya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119700/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 9:10 a.m.)
>
>
> Review request for Marble.
>
>
> Repository: marble
>
>
> Description
> -------
>
> This patch allows cancelling of the recording of the tour while it is still getting recorded, and cleans it up properly when the recording is cancelled
>
>
> Diffs
> -----
>
> src/lib/marble/MovieCapture.h 33d7bd1
> src/lib/marble/MovieCapture.cpp 6146cf2
> src/lib/marble/TourCaptureDialog.h 7c7ed70
> src/lib/marble/TourCaptureDialog.cpp e82e9a1
> src/lib/marble/TourCaptureDialog.ui 86af32d
>
> Diff: https://git.reviewboard.kde.org/r/119700/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sanjiban Bairagya
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140811/c296456f/attachment.html>
More information about the Marble-devel
mailing list