[Marble-devel] Review Request 119700: Allow cancelling tour recording, and clean up properly in that case

Sanjiban Bairagya sanjiban22393 at gmail.com
Mon Aug 11 09:10:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119700/
-----------------------------------------------------------

(Updated Aug. 11, 2014, 2:40 p.m.)


Review request for Marble.


Changes
-------

"Close" button is disabled when the tour is getting recorded, and gets re-enabled after cancellation/completion of recording. "Start" button changes to "Cancel" when recording and gets back to "Start" after cancelling the recording, and also on completing of video-recording


Repository: marble


Description
-------

This patch allows cancelling of the recording of the tour while it is still getting recorded, and cleans it up properly when the recording is cancelled


Diffs (updated)
-----

  src/lib/marble/MovieCapture.h 33d7bd1 
  src/lib/marble/MovieCapture.cpp 6146cf2 
  src/lib/marble/TourCaptureDialog.h 7c7ed70 
  src/lib/marble/TourCaptureDialog.cpp e82e9a1 
  src/lib/marble/TourCaptureDialog.ui 86af32d 

Diff: https://git.reviewboard.kde.org/r/119700/diff/


Testing
-------


Thanks,

Sanjiban Bairagya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140811/0119c675/attachment.html>


More information about the Marble-devel mailing list