[Marble-devel] Review Request 119633: Added insert method to GeoDataLineString class

Cruceru Calin-Cristian crucerucalincristian at gmail.com
Wed Aug 6 11:44:39 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119633/
-----------------------------------------------------------

(Updated Aug. 6, 2014, 2:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Repository: marble


Description
-------

This patch adds GeoDataLineString::insert method.
Since all the others node-handling GeoDataLineString methods are just wrappers over QVector methods, so is this insert method. I need this for inserting nodes in a polyline (on which I'm working atm). Also, this would ease the implementation of adding nodes to polygons as well since GeoDataLinearRing inherits GeoDataLineString and uses the same methods for handling nodes (at the moment the adding is done by shifting the nodes and appending - but this is not possible for polylines).


Diffs
-----

  src/lib/marble/geodata/data/GeoDataLineString.h 58b4009 
  src/lib/marble/geodata/data/GeoDataLineString.cpp 0a82f46 

Diff: https://git.reviewboard.kde.org/r/119633/diff/


Testing
-------

I even used it for adding nodes to polylines and works fine.


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140806/2ed86cee/attachment.html>


More information about the Marble-devel mailing list