[Marble-devel] Review Request 117524: Bug 333244 - Equality operators for model related classes

[Cruceru Calin-Cristian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117524/
-----------------------------------------------------------

(Updated April 25, 2014, 9:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Bugs: 333244
    http://bugs.kde.org/show_bug.cgi?id=333244


Repository: marble


Description
-------

Added operator== and operator!= to the class GeoDataModel and its related classes GeoDataScale, GeoDataOrientation, GeoDataLocation and GeoDataResourceMap. Extended TestEquality by a new unit test method for each class which verifies the implementation for several instances of each class.


Although it was not the purpose of this patch, I also added a "using GeoDataObject::equals" in GeoDataOverlay.h (to avoid the warnings which said that GeoDataObject::equals was hidden by GeoDataOverlay::equals) and also called GeoDataObject::equals(other) in GeoDataOverlay::equals.


Diffs
-----

  src/lib/marble/geodata/data/GeoDataLocation.h 1e59597 
  src/lib/marble/geodata/data/GeoDataLocation.cpp d0d4b18 
  src/lib/marble/geodata/data/GeoDataModel.h 031032a 
  src/lib/marble/geodata/data/GeoDataModel.cpp b7fee49 
  src/lib/marble/geodata/data/GeoDataOrientation.h 4546c00 
  src/lib/marble/geodata/data/GeoDataOrientation.cpp 935b027 
  src/lib/marble/geodata/data/GeoDataOverlay.h aeaae16 
  src/lib/marble/geodata/data/GeoDataOverlay.cpp 8a8c492 
  src/lib/marble/geodata/data/GeoDataResourceMap.h e6fc407 
  src/lib/marble/geodata/data/GeoDataResourceMap.cpp 2beb074 
  src/lib/marble/geodata/data/GeoDataScale.h 0c88fa8 
  src/lib/marble/geodata/data/GeoDataScale.cpp 05db6b4 
  tests/TestEquality.cpp 02bd179 

Diff: https://git.reviewboard.kde.org/r/117524/diff/


Testing
-------

Tested using tests/TestEquality and works fine.


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140425/9e0fb652/attachment.html>